On Tue, Apr 22, 2025 at 12:16:55PM +0530, T Pratham wrote: > Hi > > I was reading into crypto engine APIs from the kernel documentation as well as other crypto drivers using them, for their proper usage. I found some seemingly contradictory stuff from both sources. > > [1] says the following: > > You must put, at the start of your transform context your_tfm_ctx, the structure crypto_engine: That comment is obsolete: commit e5e7eb023f24653b07329162b6359283b3a03a20 Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Date: Sun Aug 13 14:54:49 2023 +0800 crypto: engine - Move crypto_engine_ops from request into crypto_alg For an example of what the driver should look like see: commit 07e34cd39282af37160c978abf18308d5bb287e3 Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Date: Sun Aug 13 14:54:51 2023 +0800 crypto: sun8i-ce - Use new crypto_engine_op interface Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt