* Dr. David Alan Gilbert (linux@xxxxxxxxxxx) wrote: > * Simon Horman (horms@xxxxxxxxxx) wrote: > > On Thu, Apr 17, 2025 at 04:32:32PM +0100, linux@xxxxxxxxxxx wrote: > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx> > > > > > > Remove three functions that are no longer used. > > > > > > rxrpc_get_txbuf() last use was removed by 2020's > > > commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and > > > local processor work") > > > > > > rxrpc_kernel_get_epoch() last use was removed by 2020's > > > commit 44746355ccb1 ("afs: Don't get epoch from a server because it may be > > > ambiguous") > > > > > > rxrpc_kernel_set_max_life() last use was removed by 2023's > > > commit db099c625b13 ("rxrpc: Fix timeout of a call that hasn't yet been > > > granted a channel") > > > > > > Both of the rxrpc_kernel_* functions were documented. Remove that > > > documentation as well as the code. > > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx> > > > > Hi David, > > Hi Simon, > > > This patch doesn't apply to net-next. Probably because of commit > > 23738cc80483 ("rxrpc: Pull out certain app callback funcs into an ops > > table"). So please rebase and repost. > > Yeh no problem. v2 sent, see message 20250422235147.146460-1-linux@xxxxxxxxxxx (I left off your Reviewed-by since it deserves a recheck!) Dave > > But other than that, this patch looks good to me. > > > Reviewed-by: Simon Horman <horms@xxxxxxxxxx> > > Thanks! > > Dave > > > > ... > > > > -- > > pw-bot: changes-requested > -- > -----Open up your eyes, open up your mind, open up your code ------- > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ > \ dave @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/ > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/