On Tue, Apr 15, 2025 Krzysztof Kozlowski wrote: > > 1 file changed, 88 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-wl-icled.yaml > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-wl-icled.yaml b/Documentation/devicetree/bindings/leds/leds-wl-icled.yaml > > new file mode 100644 > > index 000000000000..bf79c7a1719b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-wl-icled.yaml > > @@ -0,0 +1,88 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/leds-wl-icled.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LED driver for WL-ICLEDs from Wurth Elektronik. > > driver as Linux driver? Then drop and describe hardware. Sorry, I am not sure I quite understand what you mean here? Add "linux LED driver" to title? > Also drop full stop Ok, understood. > > + > > +maintainers: > > + - Ante Knezic <ante.knezic@xxxxxxxxxxx> > > + > > +description: | > > + The WL-ICLEDs are RGB LEDs with integrated controller that can be > > + daisy-chained to arbitrary number of LEDs. Communication with LEDs is > > + via SPI interface and can be single or two wire, depending on the model. > > + For more product information please see the link below: > > + https://www.we-online.com/en/components/products/WL-ICLED > > + > > +properties: > > + compatible: > > + enum: > > + - we,1315x246 > > + - we,1315x002 > > + - we,131x000 > > + - we,131161x > > + - we,131212x > > Is that a wildcard in each compatible? Unfortunatelly, yes. Exact model names are quite elaborate, yet similar enough: 1315050930246 --> we,1315x246 1315050930002 --> we,1315x002 1313210530000 --> we,131x000 1312020030000 we,131x000 1311610030140 --> we,131161x 1312121320437 --> we,131212x This seemed easier than writing complete model number... You want compatible expanded to full number anyway?