On 4/15/25 15:33, Sean Anderson wrote: > +#else /* CONFIG_PCS */ > +static inline void pcs_put(struct device *dev, struct phylink_pcs *handle) > +{ > +} > + > +static inline struct phylink_pcs *pcs_get(struct device *dev, const char *id) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline struct phylink_pcs *pcs_get_optional(struct device *dev, > + const char *id) > +{ > + return NULL; > +} > + > +static inline struct phylink_pcs > +*pcs_get_by_fwnode(struct device *dev, struct fwnode_handle *fwnode, > + const char *id) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline struct phylink_pcs > +*pcs_get_by_fwnode_optional(struct device *dev, struct fwnode_handle *fwnode, > + const char *id) > +{ > + return NULL; > +} > + > +static inline struct phylink_pcs *pcs_get_by_dev(struct device *dev, > + const struct device *pcs_dev) > +{ > + return -EOPNOTSUPP; > +} > +#endif > + > +#endif /* PCS_H */ These should be wrapped with ERR_PTR. Will fix for v4. --Sean