Hi Lorenzo Stoakes, On 2025/4/15 21:58, Lorenzo Stoakes wrote:
I'm sure it's fine, but I am yet to encounter somebody enabling this for an arch and saying 'I have checked to ensure we in no way rely on remapping the VDSO, VVAR or any other special mapping'. Because if you haven't, doing this breaks your arch. I hate to sound like a grumpy maintainer, but could I just ask to check whether you have, indeed, confirmed this? :)
I've done some real-world testing before submitting.Before enabling MSEAL_SYSTEM_MAPPINGS, vdso/vvar is not sealed; after enabling MSEAL_SYSTEM_MAPPINGS, vdso/vvar is sealed.
I tested the boot and shutdown of the Deepin 23 distribution, web Browse with Firefox, and document editing with LibreOffice both before and after enabling it, and I didn't encounter any issues (MSEAL_SYSTEM_MAPPINGS does cause a noticeable performance drop when outputting images via simple_drm, but I think this is expected).
Of course, I also ran the self-tests provided by tools/testing/selftests/mseal_system_mappings, and all tests passed.
I wanted to confirm if "breaks your arch" refers to the above?Do I need to perform any other kinds of tests to ensure the validity of this submission?
If so then all good. I also think we have a table somewhere in a doc that needs updating then? Jeff, can you confirm? Thanks!
Thanks! -- WangYuli
Attachment:
OpenPGP_0xC5DA1F3046F40BEE.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
