Re: [PATCH v1 03/16] iommu: Add iommu_copy_struct_to_user helper

[Matt Ochs <mochs@xxxxxxxxxx>]

> On Apr 11, 2025, at 1:37 AM, Nicolin Chen <nicolinc@xxxxxxxxxx> wrote:
> +__iommu_copy_struct_to_user(const struct iommu_user_data *dst_data,
> +    void *src_data, unsigned int data_type,
> +    size_t data_len, size_t min_len)
> +{
> + if (dst_data->type != data_type)
> + return -EINVAL;
> + if (WARN_ON(!dst_data || !src_data))
> + return -EINVAL;

The NULL pointer check should be first.


-matt