On Sat, 22 Mar 2025, Antheas Kapenekakis wrote:
> Since the rest of the driver follows this convention, apply it to the
> tt_toggle attribute as well.
>
> Suggested-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> Reviewed-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> ---
> drivers/platform/x86/oxpec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index 3bf2c597e9b00..0a5b33a842b24 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -275,9 +275,9 @@ static const struct dmi_system_id dmi_table[] = {
> /* Helper functions to handle EC read/write */
> static int read_from_ec(u8 reg, int size, long *val)
> {
> - int i;
> - int ret;
> u8 buffer;
> + int ret;
> + int i;
>
> if (!lock_global_acpi_lock())
> return -EBUSY;
> @@ -389,8 +389,8 @@ static ssize_t tt_toggle_store(struct device *dev,
> struct device_attribute *attr, const char *buf,
> size_t count)
> {
> - int rval;
> bool value;
> + int rval;
>
> rval = kstrtobool(buf, &value);
> if (rval)
> @@ -411,8 +411,8 @@ static ssize_t tt_toggle_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> int retval;
> - u8 reg;
> long val;
> + u8 reg;
>
> switch (board) {
> case oxp_mini_amd_a07:
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
