On Fri, Apr 11, 2025 at 07:12:24AM -0500, Mario Limonciello wrote:
> The idea was to walk all the bits and pick the first one that has a string
> associated with it. I was finding that sometimes the reserved bits are set
> which would get you a NULL pointer deref.
Uff, that needs a comment at least.
But you can write it a lot simpler instead:
for (i = 0; i <= ARRAY_SIZE(s5_reset_reason_txt); i++) {
if (!(value & BIT(i)))
continue;
if (s5_reset_reason_txt[i])
break;
}
Simple loop, simple statements and all easy. :-)
> Right; I was worried about that too but find_next_bit() will return the size
> argument when it doesn't find anything.
>
> So that should be s5_reset_reason_txt[32] which has the "Unknown" string.
Yeah, that definitely needs a comment above it.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
