Re: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx>, hpa@xxxxxxxxx, hch@xxxxxxxxxxxxx, nick.desaulniers+lkml@xxxxxxxxx, kuan-ying.lee@xxxxxxxxxxxxx, masahiroy@xxxxxxxxxx, samuel.holland@xxxxxxxxxx, mingo@xxxxxxxxxx, corbet@xxxxxxx, ryabinin.a.a@xxxxxxxxx, guoweikang.kernel@xxxxxxxxx, jpoimboe@xxxxxxxxxx, ardb@xxxxxxxxxx, vincenzo.frascino@xxxxxxx, glider@xxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, apopple@xxxxxxxxxx, samitolvanen@xxxxxxxxxx, kaleshsingh@xxxxxxxxxx, jgross@xxxxxxxx, andreyknvl@xxxxxxxxx, scott@xxxxxxxxxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, dvyukov@xxxxxxxxxx, pasha.tatashin@xxxxxxxxxx, ziy@xxxxxxxxxx, broonie@xxxxxxxxxx, gatlin.newhouse@xxxxxxxxx, jackmanb@xxxxxxxxxx, wangkefeng.wang@xxxxxxxxxx, thiago.bauermann@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, kees@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, jason.andryuk@xxxxxxx, snovitoll@xxxxxxxxx, xin@xxxxxxxxx, jan.kiszka@xxxxxxxxxxx, bp@xxxxxxxxx, rppt@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, pankaj.gupta@xxxxxxx, thuth@xxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, joel.granados@xxxxxxxxxx, kbingham@xxxxxxxxxx, nicolas@xxxxxxxxx, mark.rutland@xxxxxxx, surenb@xxxxxxxxxx, catalin.marinas@xxxxxxx, morbo@xxxxxxxxxx, justinstitt@xxxxxxxxxx, ubizjak@xxxxxxxxx, jhubbard@xxxxxxxxxx, urezki@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, bhe@xxxxxxxxxx, luto@xxxxxxxxxx, baohua@xxxxxxxxxx, nathan@xxxxxxxxxx, will@xxxxxxxxxx, brgerst@xxxxxxxxx
Subject: Re: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Fri, 4 Apr 2025 09:56:31 -0700
Cc: llvm@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, x86@xxxxxxxxxx
In-reply-to: <926742095b7e55099cc48d70848ca3c1eff4b5eb.1743772053.git.maciej.wieczor-retman@intel.com>
References: <cover.1743772053.git.maciej.wieczor-retman@intel.com> <926742095b7e55099cc48d70848ca3c1eff4b5eb.1743772053.git.maciej.wieczor-retman@intel.com>
User-agent: Mozilla Thunderbird

On 4/4/25 06:14, Maciej Wieczor-Retman wrote:
> +		if (__pa(p4d) != (pgtable_l5_enabled() ?
> +				  (unsigned long)pgd_val(*pgd) & PTE_PFN_MASK :
> +				  __pa(pgd)))
>  			printk(KERN_ERR "PAGETABLE BUG #00! %p <-> %p\n",

This one is pretty fugly. But I guess it's just one place and it
probably isn't worth refactoring this and the other helpers just for a
debug message.

Follow-Ups:
- Re: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte
  - From: Maciej Wieczor-Retman

References:
- [PATCH v3 00/14] kasan: x86: arm64: KASAN tag-based mode for x86
  - From: Maciej Wieczor-Retman
- [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte
  - From: Maciej Wieczor-Retman

Prev by Date: Re: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock Enclave
Next by Date: Re: [PATCH v3 09/14] x86: Minimal SLAB alignment
Previous by thread: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte
Next by thread: Re: [PATCH v3 06/14] x86: Physical address comparisons in fill_p*d/pte
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]