On Mon, Mar 03 2025 at 22:34, Huacai Chen wrote: > On Mon, Mar 3, 2025 at 6:15 PM Tianyang Zhang <zhangtianyang@xxxxxxxxxxx> wrote: >> +static const struct irq_domain_ops loongarch_redirect_domain_ops = { >> + .alloc = loongarch_irq_redirect_alloc, >> + .free = loongarch_irq_redirect_free, >> + .select = msi_lib_irq_domain_select, >> +}; > For consistency, please use: > static const struct irq_domain_ops redirect_domain_ops = { > .alloc = redirect_domain_alloc, > .free = redirect_domain_free, > .select = msi_lib_irq_domain_select, > }; This formatting requirement applies to all structures in this patch. See https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#coding-style-notes for further information. Thanks, tglx