On 8/18/25 2:16 PM, Kalra, Ashish wrote:
On 8/16/2025 3:39 AM, Herbert Xu wrote:
On Mon, Aug 11, 2025 at 08:30:25PM +0000, Ashish Kalra wrote:
Hi Herbert, can you please merge patches 1-5.
Paolo/Sean/Herbert, i don't know how do you want handle cross-tree merging
for patches 6 & 7.
These patches will be at the base of the cryptodev tree for 6.17
so it could be pulled into another tree without any risks.
Cheers,
Thanks Herbert for pulling in patches 1-5.
Paolo, can you please merge patches 6 and 7 into the KVM tree.
Hi Ashish,
I have pending comments on patch 7:
https://lore.kernel.org/kvm/e32a48dc-a8f7-4770-9e2f-1f3721872a63@xxxxxxx/
If still not welcome, can you say why you think:
1. The ciphertext_hiding_asid_nr variable is necessary
2. The isdigit(ciphertext_hiding_asids[0])) check is needed when it's
immediately followed by kstrtoint which effectively makes the open-coded
isdigit check redundant?
3. Why the 'invalid_parameter:' label referenced by only one goto
statement can't be folded and removed.
Thanks,
Kim
