On Wed, Jul 23, 2025 at 11:51:10PM +0530, Harsh Jain wrote: > > diff --git a/crypto/df_sp80090a.c b/crypto/df_sp80090a.c > new file mode 100644 > index 000000000000..bde5139ba163 > --- /dev/null > +++ b/crypto/df_sp80090a.c > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * NIST SP800-90A DRBG derivation function > + * > + * Copyright (C) 2014, Stephan Mueller <smueller@xxxxxxxxxx> > + */ > + > +#include <crypto/df_sp80090a.h> > +#include <crypto/drbg.h> Please include header files directly rather than relying on indirect inclusions that can disappear at any time. You should add these ones at least: #include <linux/errno.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/string.h> Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
