On Thu, Aug 28, 2025 at 12:01:29AM +0200, David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Cc: Tvrtko Ursulin <tursulin@xxxxxxxxxxx> > Cc: David Airlie <airlied@xxxxxxxxx> > Cc: Simona Vetter <simona@xxxxxxxx> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> LGTM, so: Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> > --- > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > index c16a57160b262..031d7acc16142 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > @@ -779,7 +779,7 @@ __i915_gem_object_get_page(struct drm_i915_gem_object *obj, pgoff_t n) > GEM_BUG_ON(!i915_gem_object_has_struct_page(obj)); > > sg = i915_gem_object_get_sg(obj, n, &offset); > - return nth_page(sg_page(sg), offset); > + return sg_page(sg) + offset; > } > > /* Like i915_gem_object_get_page(), but mark the returned page dirty */ > -- > 2.50.1 >
