Re: [PATCH] smb: Use arc4 library instead of duplicate arc4 code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 08, 2025 at 04:33:18AM +1000, ronnie sahlberg wrote:
> On Mon, 8 Sept 2025 at 03:59, Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > Ronnie may have additional context, but it may have been forked due to
> > unrelated restrictions on the arc4 module (that had nothing to do with
> > cifs.ko very narrow usage of arc4) breaking cifs.ko.
> >
> > Ronnie,
> > Do you remember the context?
> 
> Yepp.
> The context was that to my understanding it was suggested that the
> arc4 module would be going away
> and would be removed so cifs had to stop using it. (or create its own
> private copy)
> 
> Must been a misunderstanding of what/how would happen with arc4 when
> it was retired.
> 

Looks like it was this thread:
https://lore.kernel.org/linux-cifs/YRXlwDBfQql36wJx@sol.localdomain/T/#u

Ard and I suggested that, *if* the MD4 code has no other users, it
should be *moved* into fs/cifs/.  Unfortunately, it turned out it does
have another user: iwd uses MD4 via AF_ALG.  But either way, we never
suggested adding a duplicate copy of either the MD4 or ARC4 code.

- Eric




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux