On Wed, Sep 10, 2025 at 08:06:56PM +0200, Ard Biesheuvel wrote: > > If the algorithm is asynchronous, it may return -EINPROGRESS to the > caller, and proceed to access the request structure after that. So > this only works if the caller waits on the completion, and does not > return (and release its stack frame) before the request is completed. > > This makes this feature rather limited in usefulness imo - truly async > hashes are only performant (if they ever are) if many requests can be > in flight at the same time, and using stack requests makes that > impossible. This patch was meant to deal with the storage subsystem usage of ahash where the caller always waited for the hash to complete synchronously. In that particular context, it would be safe to use a request object on the stack if it was not also used for DMA. Of course it turned out that this won't be useful for other reasons, so I'll just drop this. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
