On Thu, Jul 31, 2025 at 11:27:50PM +0200, Matthieu Baerts wrote: > Hi Eric, > > On 31/07/2025 21:50, Eric Biggers wrote: > > Now that there are easy-to-use HMAC-SHA256 library functions, use these > > in net/mptcp/crypto.c instead of open-coding the HMAC algorithm. > > > > Remove the WARN_ON_ONCE() for messages longer than SHA256_DIGEST_SIZE. > > The new implementation handles all message lengths correctly. > > > > The mptcp-crypto KUnit test still passes after this change. > > Thank you for this patch! It is a good idea, and it looks good to me! > > Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx> > > One small detail: net-next is currently closed [1], and I don't think > this patch can be applied in -net. So except if you plan to take it in > the libcrypto tree for 6.17 -- but that's probably strange -- what I can > do is to apply it in the MPTCP tree, and send it to net-next later on. > Is this OK for you? > > [1] https://patchwork.hopto.org/net-next.html > > Cheers, > Matt > -- The MPTCP tree (and then net-next) for 6.18 is fine. I know this isn't a great time to send patches, but I just happened to have some time now. - Eric
