[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Thursday, July 24, 2025 1:39 PM > To: Jain, Harsh (AECG-SSW) <h.jain@xxxxxxx>; Krzysztof Kozlowski > <krzk@xxxxxxxxxx>; herbert@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux- > crypto@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Botcha, Mounika > <Mounika.Botcha@xxxxxxx>; Savitala, Sarat Chand > <sarat.chand.savitala@xxxxxxx>; Dhanawade, Mohan > <mohan.dhanawade@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; > smueller@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx > Subject: Re: [PATCH v4 1/3] dt-bindings: crypto: Add node for True Random > Number Generator > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 24/07/2025 10:04, Jain, Harsh (AECG-SSW) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >> Sent: Thursday, July 24, 2025 12:52 PM > >> To: Jain, Harsh (AECG-SSW) <h.jain@xxxxxxx>; > herbert@xxxxxxxxxxxxxxxxxxx; > >> davem@xxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; > >> Botcha, Mounika <Mounika.Botcha@xxxxxxx>; Savitala, Sarat Chand > >> <sarat.chand.savitala@xxxxxxx>; Dhanawade, Mohan > >> <mohan.dhanawade@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; > >> smueller@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx > >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> Subject: Re: [PATCH v4 1/3] dt-bindings: crypto: Add node for True Random > >> Number Generator > >> > >> Caution: This message originated from an External Source. Use proper caution > >> when opening attachments, clicking links, or responding. > >> > >> > >> On 23/07/2025 20:21, Harsh Jain wrote: > >>> From: Mounika Botcha <mounika.botcha@xxxxxxx> > >>> > >>> Add TRNG node compatible string and reg properities. > >>> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> > >> Why did you placed my tag here? > > > > You shared Reviewed-by on v3. It’s the same patch. Isn't I am supposed to add it > in subsequent patches if there is not change? > > > > https://lore.kernel.org/linux-crypto/20250617-rational-benign-woodpecker- > 6ee31a@kuoka/ > > And who sent the patch? Who received the tag? Why the tag is above > existing SoB chain? You means to say order of tags should be Signed-off-by: Mounika Botcha <mounika.botcha@xxxxxxx> Signed-off-by: Harsh Jain <h.jain@xxxxxxx> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > >> > >>> Signed-off-by: Mounika Botcha <mounika.botcha@xxxxxxx> > >>> Signed-off-by: Harsh Jain <h.jain@xxxxxxx> > >> > >> Who received the tag? When was the patch prepared? > > > > Did I missed something here? > > Yes, using standard tools for the job - b4 - or following the process > if you do not want to use the tools. > > Best regards, > Krzysztof