On Thu, Jun 12, 2025 at 10:55:42AM +0530, Harsh Jain wrote: > Export drbg_ctr_df() derivative function to re-use it in xilinx trng > driver. Changes has been tested by enabling CONFIG_CRYPTO_USER_API_RNG_CAVP > > Signed-off-by: Harsh Jain <h.jain@xxxxxxx> > --- > crypto/drbg.c | 108 +++++++++++++++------------- > drivers/crypto/Kconfig | 2 + > drivers/crypto/xilinx/xilinx-trng.c | 32 ++++++++- > include/crypto/drbg.h | 15 ++++ > 4 files changed, 103 insertions(+), 54 deletions(-) Please move the df function out into its own module like crypto/hkdf.c. You should also keep the drbg changes to a minimum. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt