[PATCH] crypto: aspeed - Fix hash fallback path typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 23, 2025 at 06:55:06PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   82a0302e7167d0b7c6cde56613db3748f8dd806d
> commit: 508712228696eaddc4efc706e6a8dd679654f339 [11/61] crypto: aspeed/hash - Add fallback
> config: arm-randconfig-r073-20250623 (https://download.01.org/0day-ci/archive/20250623/202506231830.us4hiwlZ-lkp@xxxxxxxxx/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.3.0
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of

Thanks for the report!

---8<---
Fix typo in the fallback code path.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202506231830.us4hiwlZ-lkp@xxxxxxxxx/
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

diff --git a/drivers/crypto/aspeed/aspeed-hace-hash.c b/drivers/crypto/aspeed/aspeed-hace-hash.c
index e54b7dd03be3..f8f37c9d5f3c 100644
--- a/drivers/crypto/aspeed/aspeed-hace-hash.c
+++ b/drivers/crypto/aspeed/aspeed-hace-hash.c
@@ -449,7 +449,7 @@ static noinline int aspeed_ahash_fallback(struct ahash_request *req)
 	if (rctx->flags & SHA_FLAGS_FINUP)
 		ret = ret ?: crypto_ahash_finup(fbreq);
 	else
-		ret = ret ?: crypto_ahash_update(fbreq);
+		ret = ret ?: crypto_ahash_update(fbreq) ?:
 			     crypto_ahash_export_core(fbreq, state) ?:
 			     aspeed_sham_import(req, state);
 	HASH_REQUEST_ZERO(fbreq);
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux