Hi Krzysztof, Yes, I do understand the use of static tools and the W=1 warning checks on gcc/clang. Anything missed here is not intentional and I am ready to add more tests and checks before posting patches. I use Sparse, which did not show any errors or warnings in the code. make C=1 CHECK="sparse" M=drivers/crypto/dwc-spacc/ make C=2 CHECK="sparse" M=drivers/crypto/dwc-spacc/ I missed Coccinelle, because I had installation problems on my Ubuntu 20.04 workstation, which has the build setup and my cross compilers. I installed and checked SPAcc code with Coccinelle on another workstation and I do see errors/warnings in the code. I will fix all these and any new ones going forward. cocci.log:25:./spacc_device.c:132:2-9: line 132 is redundant because platform_get_irq() already prints an error cocci.log:27:./spacc_device.c:301:3-8: No need to set .owner here. The core will do it. cocci.log:50:./spacc_aead.c:575:8-15: ERROR: iterator variable bound on line 572 cannot be NULL cocci.log:51:./spacc_skcipher.c:202:8-15: ERROR: iterator variable bound on line 199 cannot be NULL cocci.log:52:./spacc_ahash.c:288:8-15: ERROR: iterator variable bound on line 285 cannot be NULL cocci.log:59:./spacc_interrupt.c:117:1-7: preceding lock on line 97 (false positive) Also I do the W=1 warning checks with my .config on gcc and clang COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-13.2.0 ~/lkp-tests/kbuild/make.cross W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__ -fmax-errors=unlimited -fmax-warnings=unlimited' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/crypto/dwc-spacc/ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-14.1.0 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/crypto/ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-17 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arm64 drivers/crypto/dwc-spacc Warm regards, PK On Tue, Jun 3, 2025 at 5:37 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 03/06/2025 14:02, Pavitrakumar Managutte wrote: > > >> Please run standard kernel tools for static analysis, like coccinelle, > >> smatch and sparse, and fix reported warnings. Also please check for > >> warnings when building with W=1 for gcc and clang. Most of these > >> commands (checks or W=1 build) can build specific targets, like some > >> directory, to narrow the scope to only your code. The code here looks > >> like it needs a fix. Feel free to get in touch if the warning is not clear. > >> > Confirm that you understood this. You sent us code with obvious flaws > which would be found with tools. It's a proof you did not run these > static tools. It's not the job of community reviewers to replace the > tools. Using us instead of tools is... well, a mistake but if you think > about our limited time then kind of close to inappropriate request. So > did you understand the need of using tools BEFORE you post it? > > Best regards, > Krzysztof
