On 5/28/25 15:20, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@xxxxxxx>
>
> Fix below smatch warnings:
> drivers/crypto/ccp/sev-dev.c:1312 __sev_platform_init_locked()
> error: we previously assumed 'error' could be null
>
> Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/r/202505071746.eWOx5QgC-lkp@xxxxxxxxx/
> Signed-off-by: Ashish Kalra <ashish.kalra@xxxxxxx>
Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> ---
> drivers/crypto/ccp/sev-dev.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 3451bada884e..8fb94c5f006a 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -1276,9 +1276,11 @@ static int __sev_platform_init_handle_init_ex_path(struct sev_device *sev)
>
> static int __sev_platform_init_locked(int *error)
> {
> - int rc, psp_ret = SEV_RET_NO_FW_CALL;
> + int rc, psp_ret, dfflush_error;
> struct sev_device *sev;
>
> + psp_ret = dfflush_error = SEV_RET_NO_FW_CALL;
> +
> if (!psp_master || !psp_master->sev_data)
> return -ENODEV;
>
> @@ -1320,10 +1322,10 @@ static int __sev_platform_init_locked(int *error)
>
> /* Prepare for first SEV guest launch after INIT */
> wbinvd_on_all_cpus();
> - rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, error);
> + rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, &dfflush_error);
> if (rc) {
> dev_err(sev->dev, "SEV: DF_FLUSH failed %#x, rc %d\n",
> - *error, rc);
> + dfflush_error, rc);
> return rc;
> }
>
