On Mon, Mar 10, 2025 at 09:36:51PM -0700, Eric Biggers wrote: > > Actually this new function is useless as-is, since it invokes undefined behavior > when the source and destination coincide (which can happen even when src == > dst), and all the potential callers need to handle that case. I'm working on a > fixed version. Yes I just tried using it in chacha20poly1305 and it was no good, as it can't deal with the partially identical SG lists that IPsec creates. So I've fixed it by rewriting it based on skcipher_walk. In order to do so I've moved the common bits of skcipher_walk out of skcipher and into scatterwalk. This should be good enough to replace skcipher_null. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
