On 23/04/2025 12:15, Pavitrakumar M wrote: > From: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> > > Add DT bindings related to the SPAcc driver for Documentation. > DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto These IP blocks are rarely usable on their own and need SoC customization. Where any SoC users? Where are any SoC compatibles? <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. </form letter> > Engine is a crypto IP designed by Synopsys. > > Co-developed-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> > Signed-off-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> > Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> > Acked-by: Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > --- > .../bindings/crypto/snps,dwc-spacc.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml b/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml > new file mode 100644 > index 000000000000..ffd4af5593a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/snps,dwc-spacc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synopsys DesignWare Security Protocol Accelerator(SPAcc) Crypto Engine > + > +maintainers: > + - Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > + > +description: > + DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto Engine is > + a crypto IP designed by Synopsys, that can accelerate cryptographic > + operations. > + > +properties: > + compatible: > + items: > + - const: snps,dwc-spacc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + snps,vspacc-priority: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Set priority mode on the Virtual SPAcc. This is Virtual SPAcc priority > + weight. Its used in priority arbitration of the Virtual SPAccs. Why would this be board configuration? > + minimum: 0 > + maximum: 15 > + default: 0 > + > + snps,vspacc-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Virtual spacc index for validation and driver functioning. Driver? Bindings are for hardware, not driver. You described the desired Linux feature or behavior, not the actual hardware. The bindings are about the latter, so instead you need to rephrase the property and its description to match actual hardware capabilities/features/configuration etc. > + minimum: 0 > + maximum: 7 > + > + snps,spacc-wdtimer: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Watchdog timer count to replace the default value in driver. If this is watchdog, then use existing watchdog schema and its property. If this is something else then... well, it cannot be something for driver, so then drop. > + minimum: 0x19000 > + maximum: 0xFFFFF > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + crypto@40000000 { > + compatible = "snps,dwc-spacc"; > + reg = <0x40000000 0x3FFFF>; > + interrupt-parent = <&gic>; > + interrupts = <0 89 4>; Use proper defines for typical flags. Best regards, Krzysztof
