Hi Eric, (replaying my response to v1, which I wrote before I noticed there was a v2) On Tue, 22 Apr 2025 at 17:23, Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > CONFIG_CRYPTO_TEST enables a benchmarking module that is only really > useful for developers working on the crypto subsystem. It is in a bunch > of defconfigs. But as with most of the other crypto options that tend > to be randomly set in defconfigs, it is unlikely that much thought was > put into these, especially when placed in "production" defconfigs. > Clear it out of the defconfigs for now. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> Thanks for your patch! All of these are modular, so I don't think it's a big issue, even on "production" defconfigs. It just means the test is available when someone feels the urge to run it. Hence I try to make all tests available as modules in m68k defconfigs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds