Re: [PATCH] crypto: public_key - Make sig/tfm local to if clause in software_key_query

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 16, 2025 at 03:48:26PM +0800, Herbert Xu wrote:
> The recent code changes in this function triggered a false-positive
> maybe-uninitialized warning in software_key_query.  Rearrange the
> code by moving the sig/tfm variables into the if clause where they
> are actually used.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Hm, I've tried to reproduce the warning with W=1 and W=2 to no avail
(with gcc 14).  How did you trigger it?

FWIW,
Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>

I suppose this may have been introduced by 63ba4d67594a ("KEYS:
asymmetric: Use new crypto interface without scatterlists").

Thanks,

Lukas




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux