Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 14 Apr 2025 10:03:54 -0400
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, Ard Biesheuvel <ardb@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
In-reply-to: <20250413154350.10819-1-ebiggers@kernel.org> (Eric Biggers's message of "Sun, 13 Apr 2025 08:43:50 -0700")
Organization: Oracle Corporation
References: <20250413154350.10819-1-ebiggers@kernel.org>

Eric,

> All of the CRC library's CPU feature static_keys are initialized by
> initcalls and never change afterwards, so there's no need for them to
> be in the regular .data section. Put them in .data..ro_after_init
> instead.

LGTM.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen

References:
- [PATCH] lib/crc: make the CPU feature static keys __ro_after_init
  - From: Eric Biggers

Prev by Date: [PATCH] crypto: ecdsa - explicitly zeroize pub_key
Next by Date: Re: [PATCH 3/4] crypto: sun8i-ss - use API helpers to setup fallback request
Previous by thread: Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init
Next by thread: Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux