On Sun, Apr 13, 2025 at 09:03:04AM -0700, Eric Biggers wrote: > > Why does this make any sense? The lifetime of the algorithm struct memory > should be the same as that of the owning module, and drivers should ensure that. > In which case hacks like this are not needed. Hardware can be unplugged at any time. Once all hardware backing a driver has been removed, you need to unregister that algorithm. Please read my explanation for the prior patch: https://patchwork.kernel.org/project/linux-crypto/patch/Z_XpfyPaoZ6Y8u6z@xxxxxxxxxxxxxxxxxxx/ Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt