On Wed, Apr 02, 2025 at 09:28:47AM -0700, Eric Biggers wrote: > On Wed, Apr 02, 2025 at 10:01:07AM -0400, Kent Overstreet wrote: > > On Tue, Apr 01, 2025 at 09:33:33PM -0700, Eric Biggers wrote: > > > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > > > Just use the ChaCha20 and Poly1305 libraries instead of the clunky > > > crypto API. This is much simpler. It is also slightly faster, since > > > the libraries provide more direct access to the same > > > architecture-optimized ChaCha20 and Poly1305 code. > > > > > > I've tested that existing encrypted bcachefs filesystems can be continue > > > to be accessed with this patch applied. > > > > > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > Fantastic! > > > > Applied, and this should go into 6.15 - this should get the strange bugs > > in the poly1305 path that I wasn't able to reproduce off the dashboard > > (and if they're still there, they'll be much easier to debug.) > > Thanks! > > If you're referring to > https://lore.kernel.org/r/CAHOo4gLWAbArwg+w+AqqkxGmOFX6cm8Tvy85tb4igN6V7Z9BZQ@xxxxxxxxxxxxxx/, > I think bcachefs passed invalid memory to Poly1305 as a result of mounting a > fuzzed filesystem image. So it should be unaffected by this patch. Well, in that case your patch should still get us a backtrace that I can actually debug :)
