On Wed, 2 Apr 2025 at 09:31, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > On Wed, 2 Apr 2025 at 06:14, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > > > Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > > > Stop wrapping skcipher and aead algorithms with the crypto simd helper > > > (crypto/simd.c). The only purpose of doing so was to work around x86 > > > not always supporting kernel-mode FPU in softirqs. Specifically, if a > > > hardirq interrupted a task context kernel-mode FPU section and then a > > > softirqs were run at the end of that hardirq, those softirqs could not > > > use kernel-mode FPU. This has now been fixed. In combination with the > > > fact that the skcipher and aead APIs only support task and softirq > > > contexts, these can now just use kernel-mode FPU unconditionally on x86. > > > > Nice work! > > > > Yeah good riddance. > > > So which platform still needs the simd wrapper? I believe arm/arm64 > > have both been fixed but we haven't finished removing the legacy > > simd code yet? Ard, would you be able to spare some cycles and > > finish the removal of simd on arm? > > > > Removal of what, exactly? Ah, never mind - I see some calls on 32-bit ARM to simd_skcipher_create_compat(), which have become redundant now that SIMD is guaranteed to be available in softirq context.
