On Wed, Mar 26, 2025 at 03:59:45PM +0000, Giovanni Cabiddu wrote: > This series of patches addresses the warm reboot problem that affects > all QAT devices. When a reset is performed using kexec, QAT devices > fail to recover due to improper shutdown. Thanks for the quick fixes Giovanni! As this is not a new regression, I think they should go through the usual release cycle. Just one comment on a possible improvement though, while it's good to shut down the device properly, the initialisation side should also do as much as is possible to reset a device that is in an unknown state. This is because the previous kernel might have had a hard crash, in which case there is no chance for the correct shutdown sequence to be carried out. Of course it's not always physically possible to reset something that is in an unknown state, but we should design the driver to be as resilient as possible. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
