Hi Herbert, On 18:05-20250326, Herbert Xu wrote: > On Wed, Mar 26, 2025 at 03:30:27PM +0530, Manorit Chawdhry wrote: > > > > Thanks for the quick fix, though now I see error in import rather than > > init which was there previously. > > Oops, I removed one line too many from the import function. It > should set the tfm just like init: > > ---8<--- > Rather than setting up a request by hand, use the correct API helpers > to setup the new request. This is because the API helpers will setup > chaining. > > Also change the fallback allocation to explicitly request for a > sync algorithm as this driver will crash if given an async one. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks for the fix! Although, it still fails probably due to the introduction of multibuffer hash testing in "crypto: testmgr - Add multibuffer hash testing" but that we will have to fix for our driver I assume. [ 32.408283] alg: ahash: sha1-sa2ul digest() failed on test vector 0; expected_error=0, actual_error=-22, cfg="random: inplace_two_sglists may_sleep use_digest multibuffer(9/13/uneven) src_divs=[100.0%@+860] key_offset=17" [...] [ 32.885927] alg: ahash: sha512-sa2ul digest() failed on test vector 0; expected_error=0, actual_error=-22, cfg="random: use_digest multibuffer(6/9/uneven) nosimd src_divs=[93.34%@+3634, 6.66%@+16] iv_offset=9 key_offset=70" [...] [ 33.135286] alg: ahash: sha256-sa2ul digest() failed on test vector 0; expected_error=0, actual_error=-22, cfg="random: inplace_two_sglists may_sleep use_digest multibuffer(15/16/uneven) src_divs=[100.0%@alignmask+26] key_offset=1" Tested-by: Manorit Chawdhry <m-chawdhry@xxxxxx> Regards, Manorit
