Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Liao,


Thank you for the patch.

Am 18.08.25 um 14:36 schrieb Liao Yuanhong:
The hci_uart struct is already zeroed by kzalloc(). It's redundant to
initialize hu->padding to 0.

Signed-off-by: Liao Yuanhong <liaoyuanhong@xxxxxxxx>
---
  drivers/bluetooth/hci_ldisc.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index d0adae3267b4..e7a55c2e63f1 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
/* disable alignment support by default */
  	hu->alignment = 1;
-	hu->padding = 0;
/* Use serial port speed as oper_speed */
  	hu->oper_speed = tty->termios.c_ospeed;

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux