Hi Dmitry
On 8/16/2025 5:50 AM, Dmitry Baryshkov wrote:
> On Thu, Aug 14, 2025 at 08:47:02PM +0800, Shuai Zhang wrote:
>> After SSR, host will not download the firmware, causing
>> controller to remain in the IBS_WAKE state. Host needs
>> to synchronize with the controller to maintain proper operation.
>
> It totally feels like all these patches fix the same issue and should be
> squashed together. Please also add a sensible Fixes: tag. Possibly
> add cc:stable too.
Although these issues are all related to SSR, the underlying causes of the
errors are different. Would it be appropriate to merge them into one patch?
>
>>
>> Signed-off-by: Shuai Zhang <quic_shuaz@xxxxxxxxxxx>
>> ---
>> drivers/bluetooth/hci_qca.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index 91009c6a7..d37cd2368 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1660,10 +1660,14 @@ static void qca_hw_error(struct hci_dev *hdev, u8 code)
>> * QCA_IBS_DISABLED flags cannot be cleared, which leads to a reset
>> * command timeout.
>> * Add an msleep delay to ensure controller completes the SSR process.
>> + *
>> + * Host will not download the firmware after SSR, controller to remain
>> + * in the IBS_WAKE state, and the host needs to synchronize with it
>> */
>> if (!test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks)) {
>> clear_bit(QCA_SSR_TRIGGERED, &qca->flags);
>> clear_bit(QCA_IBS_DISABLED, &qca->flags);
>> + qca->tx_ibs_state = HCI_IBS_TX_AWAKE;
>> msleep(50);
>> }
>>
>> --
>> 2.34.1
>>
>
BR,
Shuai
