Re: [PATCH v1] Bluetooth: MGMT: Fix not exposing debug UUID on MGMT_OP_READ_EXP_FEATURES_INFO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on bluetooth/master linus/master v6.17-rc2 next-20250820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-MGMT-Fix-not-exposing-debug-UUID-on-MGMT_OP_READ_EXP_FEATURES_INFO/20250820-230851
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link:    https://lore.kernel.org/r/20250820145829.1766185-1-luiz.dentz%40gmail.com
patch subject: [PATCH v1] Bluetooth: MGMT: Fix not exposing debug UUID on MGMT_OP_READ_EXP_FEATURES_INFO
config: csky-randconfig-001-20250821 (https://download.01.org/0day-ci/archive/20250821/202508210258.dagzqWcm-lkp@xxxxxxxxx/config)
compiler: csky-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250821/202508210258.dagzqWcm-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508210258.dagzqWcm-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   net/bluetooth/mgmt.c: In function 'read_exp_features_info':
>> net/bluetooth/mgmt.c:4470:25: error: implicit declaration of function 'bt_dbg_get' [-Werror=implicit-function-declaration]
    4470 |                 flags = bt_dbg_get() ? BIT(0) : 0;
         |                         ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/bt_dbg_get +4470 net/bluetooth/mgmt.c

af6bcc1921ff0b Brian Gix              2022-09-01  4451  
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4452  static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev,
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4453  				  void *data, u16 data_len)
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4454  {
af6bcc1921ff0b Brian Gix              2022-09-01  4455  	struct mgmt_rp_read_exp_features_info *rp;
af6bcc1921ff0b Brian Gix              2022-09-01  4456  	size_t len;
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4457  	u16 idx = 0;
15d8ce05ebec37 Alain Michaud          2020-07-07  4458  	u32 flags;
af6bcc1921ff0b Brian Gix              2022-09-01  4459  	int status;
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4460  
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4461  	bt_dev_dbg(hdev, "sock %p", sk);
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4462  
af6bcc1921ff0b Brian Gix              2022-09-01  4463  	/* Enough space for 7 features */
af6bcc1921ff0b Brian Gix              2022-09-01  4464  	len = sizeof(*rp) + (sizeof(rp->features[0]) * 7);
bb20da18ce936a Yihao Han              2022-09-19  4465  	rp = kzalloc(len, GFP_KERNEL);
af6bcc1921ff0b Brian Gix              2022-09-01  4466  	if (!rp)
af6bcc1921ff0b Brian Gix              2022-09-01  4467  		return -ENOMEM;
af6bcc1921ff0b Brian Gix              2022-09-01  4468  
50912f8b707c67 Luiz Augusto von Dentz 2025-08-20  4469  	if (IS_ENABLED(CONFIG_BT_FEATURE_DEBUG)) {
15d8ce05ebec37 Alain Michaud          2020-07-07 @4470  		flags = bt_dbg_get() ? BIT(0) : 0;
e625e50ceee18b Marcel Holtmann        2020-05-06  4471  
e625e50ceee18b Marcel Holtmann        2020-05-06  4472  		memcpy(rp->features[idx].uuid, debug_uuid, 16);
e625e50ceee18b Marcel Holtmann        2020-05-06  4473  		rp->features[idx].flags = cpu_to_le32(flags);
e625e50ceee18b Marcel Holtmann        2020-05-06  4474  		idx++;
e625e50ceee18b Marcel Holtmann        2020-05-06  4475  	}
e625e50ceee18b Marcel Holtmann        2020-05-06  4476  
76d0685bbac8ae Luiz Augusto von Dentz 2021-12-22  4477  	if (hdev && hci_dev_le_state_simultaneous(hdev)) {
76d0685bbac8ae Luiz Augusto von Dentz 2021-12-22  4478  		if (hci_dev_test_flag(hdev, HCI_LE_SIMULTANEOUS_ROLES))
15d8ce05ebec37 Alain Michaud          2020-07-07  4479  			flags = BIT(0);
15d8ce05ebec37 Alain Michaud          2020-07-07  4480  		else
15d8ce05ebec37 Alain Michaud          2020-07-07  4481  			flags = 0;
15d8ce05ebec37 Alain Michaud          2020-07-07  4482  
76d0685bbac8ae Luiz Augusto von Dentz 2021-12-22  4483  		memcpy(rp->features[idx].uuid, le_simultaneous_roles_uuid, 16);
15d8ce05ebec37 Alain Michaud          2020-07-07  4484  		rp->features[idx].flags = cpu_to_le32(flags);
15d8ce05ebec37 Alain Michaud          2020-07-07  4485  		idx++;
15d8ce05ebec37 Alain Michaud          2020-07-07  4486  	}
15d8ce05ebec37 Alain Michaud          2020-07-07  4487  
258f56d11bbbf3 Joseph Hwang           2021-11-02  4488  	if (hdev && (aosp_has_quality_report(hdev) ||
258f56d11bbbf3 Joseph Hwang           2021-11-02  4489  		     hdev->set_quality_report)) {
ae7d925b5c0432 Joseph Hwang           2021-08-15  4490  		if (hci_dev_test_flag(hdev, HCI_QUALITY_REPORT))
823f3bc4e2eca7 Marcel Holtmann        2021-09-28  4491  			flags = BIT(0);
823f3bc4e2eca7 Marcel Holtmann        2021-09-28  4492  		else
ae7d925b5c0432 Joseph Hwang           2021-08-15  4493  			flags = 0;
823f3bc4e2eca7 Marcel Holtmann        2021-09-28  4494  
ae7d925b5c0432 Joseph Hwang           2021-08-15  4495  		memcpy(rp->features[idx].uuid, quality_report_uuid, 16);
ae7d925b5c0432 Joseph Hwang           2021-08-15  4496  		rp->features[idx].flags = cpu_to_le32(flags);
ae7d925b5c0432 Joseph Hwang           2021-08-15  4497  		idx++;
ae7d925b5c0432 Joseph Hwang           2021-08-15  4498  	}
ae7d925b5c0432 Joseph Hwang           2021-08-15  4499  
7f7fd17ed7c522 Marcel Holtmann        2021-09-28  4500  	if (hdev && hdev->get_data_path_id) {
ad933151832855 Kiran K                2021-09-07  4501  		if (hci_dev_test_flag(hdev, HCI_OFFLOAD_CODECS_ENABLED))
7f7fd17ed7c522 Marcel Holtmann        2021-09-28  4502  			flags = BIT(0);
7f7fd17ed7c522 Marcel Holtmann        2021-09-28  4503  		else
ad933151832855 Kiran K                2021-09-07  4504  			flags = 0;
7f7fd17ed7c522 Marcel Holtmann        2021-09-28  4505  
ad933151832855 Kiran K                2021-09-07  4506  		memcpy(rp->features[idx].uuid, offload_codecs_uuid, 16);
ad933151832855 Kiran K                2021-09-07  4507  		rp->features[idx].flags = cpu_to_le32(flags);
ad933151832855 Kiran K                2021-09-07  4508  		idx++;
ad933151832855 Kiran K                2021-09-07  4509  	}
ad933151832855 Kiran K                2021-09-07  4510  
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4511  	if (IS_ENABLED(CONFIG_BT_LE)) {
3ca23aaba210e4 Luiz Augusto von Dentz 2025-08-04  4512  		flags = iso_inited() ? BIT(0) : 0;
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4513  		memcpy(rp->features[idx].uuid, iso_socket_uuid, 16);
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4514  		rp->features[idx].flags = cpu_to_le32(flags);
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4515  		idx++;
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4516  	}
ccf74f2390d60a Luiz Augusto von Dentz 2020-01-16  4517  
af6bcc1921ff0b Brian Gix              2022-09-01  4518  	if (hdev && lmp_le_capable(hdev)) {
af6bcc1921ff0b Brian Gix              2022-09-01  4519  		if (hci_dev_test_flag(hdev, HCI_MESH_EXPERIMENTAL))
af6bcc1921ff0b Brian Gix              2022-09-01  4520  			flags = BIT(0);
af6bcc1921ff0b Brian Gix              2022-09-01  4521  		else
af6bcc1921ff0b Brian Gix              2022-09-01  4522  			flags = 0;
af6bcc1921ff0b Brian Gix              2022-09-01  4523  
af6bcc1921ff0b Brian Gix              2022-09-01  4524  		memcpy(rp->features[idx].uuid, mgmt_mesh_uuid, 16);
af6bcc1921ff0b Brian Gix              2022-09-01  4525  		rp->features[idx].flags = cpu_to_le32(flags);
af6bcc1921ff0b Brian Gix              2022-09-01  4526  		idx++;
af6bcc1921ff0b Brian Gix              2022-09-01  4527  	}
af6bcc1921ff0b Brian Gix              2022-09-01  4528  
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4529  	rp->feature_count = cpu_to_le16(idx);
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4530  
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4531  	/* After reading the experimental features information, enable
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4532  	 * the events to update client on any future change.
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4533  	 */
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4534  	hci_sock_set_flag(sk, HCI_MGMT_EXP_FEATURE_EVENTS);
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4535  
af6bcc1921ff0b Brian Gix              2022-09-01  4536  	status = mgmt_cmd_complete(sk, hdev ? hdev->id : MGMT_INDEX_NONE,
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4537  				   MGMT_OP_READ_EXP_FEATURES_INFO,
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4538  				   0, rp, sizeof(*rp) + (20 * idx));
af6bcc1921ff0b Brian Gix              2022-09-01  4539  
af6bcc1921ff0b Brian Gix              2022-09-01  4540  	kfree(rp);
af6bcc1921ff0b Brian Gix              2022-09-01  4541  	return status;
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4542  }
a10c907ce0e5e1 Marcel Holtmann        2020-05-06  4543  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux