Re: [PATCH] Bluetooth: btusb: Fixup quirk for reading ext features on some Barrot controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Could we solve this by doing:
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 3595a8bad6bd..168b07041605 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1194,6 +1194,17 @@ static int btusb_recv_intr(struct btusb_data
> *data, void *buffer, int count)
>                 }
>
>                 if (!hci_skb_expect(skb)) {
> +                       /* Each chunk should correct to at least 1 or
> more events
> +                        * so if there are still bytes left that
> doesn't constitute a new
> +                         * event this is likely a bug in the controller.
> +                        */
> +                       if (count && count < HCI_EVENT_HDR_SIZE) {
> +                               bt_dev_warn(data->hdev,
> +                                           "Unexpected continuation: %d bytes",
> +                                           count);
> +                               count = 0;
> +                       }
> +

I've just verified that this patch brings the Barrot dongle to live on
Linux. Here is the output from dmesg:

> [   43.329852] usb 1-1.4: new full-speed USB device number 4 using dwc_otg
> [   43.446790] usb 1-1.4: New USB device found, idVendor=33fa, idProduct=0012, bcdDevice=88.91
> [   43.446813] usb 1-1.4: New USB device strings: Mfr=0, Product=2, SerialNumber=0
> [   43.446821] usb 1-1.4: Product: UGREEN BT6.0 Adapter
> [   43.582024] Bluetooth: hci1: Unexpected continuation: 1 bytes
> [   43.703025] Bluetooth: hci1: Unexpected continuation: 1 bytes
> [   43.750141] Bluetooth: MGMT ver 1.23




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux