Re: [PATCH v2] Bluetooth: btusb: Check for unexpected bytes when defragmenting HCI frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arkadiusz,

On Wed, Aug 27, 2025 at 11:02 AM Arkadiusz Bokowy
<arkadiusz.bokowy@xxxxxxxxx> wrote:
>
> > Looks like we are missing:
> >
> > +       /* Barrot Technology Bluetooth devices */
> > +       { USB_DEVICE(0x33fa, 0x0010), .driver_info = BTUSB_BARROT },
> > +       { USB_DEVICE(0x33fa, 0x0012), .driver_info = BTUSB_BARROT },
> >
> > We can probably add it together in the same patch, so we don't have to
> > rely on Fixes to inform the changes below needs to go together, but
> > then we should include the contents of /sys/kernel/debug/usb/devices
> > before the information why we need the changes to detect extra bytes
> > in order for it to work.
>
> OK, so, should I restore the quirk (so this check is only for Barrot
> devices)? Or add driver_info = BARROT without actually using it
> anywhere?

I don't think we need to quirk to acting on the extra bytes, but
perhaps we should leave the driver_info = BARROT in case we need some
special handling for it since I suspect it may be needed for setting
up things like firmware download, which in the event the driver is
ever fixed to not sent the extra bytes a new firmware will probably
going to be required.

-- 
Luiz Augusto von Dentz





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux