Re: [PATCH v5 RESEND] Bluetooth: btintel: Correctly declare all module firmware files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

Was this patch applied in the end? If not, is there anything else I should do?

Cheers,

Daan De Meyer


On Wed, 27 Aug 2025 at 07:31, Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
>
> [Cc: Remove Dimitri’s bouncing address]
>
> Am 27.08.25 um 07:29 schrieb Paul Menzel:
> > Dear Daan,
> >
> >
> > Thank you for the patch.
> >
> > Am 26.08.25 um 22:29 schrieb DaanDeMeyer:
> >> From: Dimitri John Ledkov <dimitri.ledkov@xxxxxxxxxxxxx>
> >>
> >> Strictly encode patterns of supported hw_variants of firmware files
> >> the kernel driver supports requesting. This now includes many missing
> >> and previously undeclared module firmware files for 0x07, 0x08,
> >> 0x11-0x14, 0x17-0x1b hw_variants.
> >>
> >> This especially affects environments that only install firmware files
> >> declared and referenced by the kernel modules. In such environments,
> >> only the declared firmware files are copied resulting in most Intel
> >> Bluetooth devices not working. I.e. host-only dracut-install initrds,
> >> or Ubuntu Core kernel snaps.
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/1970819
> >> Cc: stable@xxxxxxxxxxxxxxx # 4.15+
> >> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@xxxxxxxxxxxxx>
> >> ---
> >> Notes:
> >>      Changes since v4:
> >>      - Add missing "intel/" prefix for 0x17+ firmware
> >>      - Add Cc stable for v4.15+ kernels
> >>      Changes since v3:
> >>      - Hopefully pacify trailing whitespace from GitLint in this optional
> >>        portion of the commit.
> >>      Changes since v2:
> >>      - encode patterns for 0x17 0x18 0x19 0x1b hw_variants
> >>      - rebase on top of latest rc tag
> >>      Changes since v1:
> >>      - encode strict patterns of supported firmware files for each of the
> >>        supported hw_variant generations.
> >>
> >>   drivers/bluetooth/btintel.c | 26 ++++++++++++++++++++++----
> >>   1 file changed, 22 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> >> index a657e9a3e96a..d0e22fe09567 100644
> >> --- a/drivers/bluetooth/btintel.c
> >> +++ b/drivers/bluetooth/btintel.c
> >> @@ -2656,7 +2656,25 @@ MODULE_AUTHOR("Marcel Holtmann
> >> <marcel@xxxxxxxxxxxx>");
> >>   MODULE_DESCRIPTION("Bluetooth support for Intel devices ver " VERSION);
> >>   MODULE_VERSION(VERSION);
> >>   MODULE_LICENSE("GPL");
> >> -MODULE_FIRMWARE("intel/ibt-11-5.sfi");
> >> -MODULE_FIRMWARE("intel/ibt-11-5.ddc");
> >> -MODULE_FIRMWARE("intel/ibt-12-16.sfi");
> >> -MODULE_FIRMWARE("intel/ibt-12-16.ddc");
> >> +/* hw_variant 0x07 0x08 */
> >> +MODULE_FIRMWARE("intel/ibt-hw-37.7.*-fw-*.*.*.*.*.bseq");
> >> +MODULE_FIRMWARE("intel/ibt-hw-37.7.bseq");
> >> +MODULE_FIRMWARE("intel/ibt-hw-37.8.*-fw-*.*.*.*.*.bseq");
> >> +MODULE_FIRMWARE("intel/ibt-hw-37.8.bseq");
> >> +/* hw_variant 0x0b 0x0c */
> >> +MODULE_FIRMWARE("intel/ibt-11-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-12-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-11-*.ddc");
> >> +MODULE_FIRMWARE("intel/ibt-12-*.ddc");
> >> +/* hw_variant 0x11 0x12 0x13 0x14 */
> >> +MODULE_FIRMWARE("intel/ibt-17-*-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-18-*-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-19-*-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-20-*-*.sfi");
> >> +MODULE_FIRMWARE("intel/ibt-17-*-*.ddc");
> >> +MODULE_FIRMWARE("intel/ibt-18-*-*.ddc");
> >> +MODULE_FIRMWARE("intel/ibt-19-*-*.ddc");
> >> +MODULE_FIRMWARE("intel/ibt-20-*-*.ddc");
> >> +/* hw_variant 0x17 0x18 0x19 0x1b, read and use cnvi/cnvr */
> >> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].sfi");
> >> +MODULE_FIRMWARE("intel/ibt-[0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9].ddc");
> >
> > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> >
> >
> > Kind regards,
> >
> > Paul





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux