When an A2DP stream is created in start_ind, a timer is set, suspending
the AVDTP stream if there have been no users within 5 seconds. However,
if the AVDTP stream transitions to the IDLE state before the timer
fires, the A2DP stream is freed without the timer being cleared. This
meant that when the timer fired, it tried to suspend a stream with a
pointer that was previously freed and so segfaulted.
This commit fixes that by ensuring that suspend_timer is cleared before
freeing the A2DP stream.
This was causing random segfaults when connecting my Sony WH-1000XM5
headphones.
Signed-off-by: Alex Studer <alex@xxxxxxxxxx>
---
profiles/audio/a2dp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index 661843a89..4e1362913 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -636,6 +636,11 @@ static void a2dp_stream_free(void *data)
{
struct a2dp_stream *stream = data;
+ if (stream->suspend_timer) {
+ timeout_remove(stream->suspend_timer);
+ stream->suspend_timer = 0;
+ }
+
avdtp_unref(stream->session);
free(stream);
}
--
2.51.0
