Re: [PATCH v3 3/4] driver: bluetooth: hci_qca: Multiple triggers of SSR only generate one coredump file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,Konrad

On 8/13/2025 7:11 PM, Konrad Dybcio wrote:
> On 8/13/25 5:35 AM, Shuai Zhang wrote:
>> Multiple triggers of SSR only first generate coredump file,
>> duo to memcoredump_flag no clear.
>>
>> add clear coredump flag when ssr completed.
>>
>> Signed-off-by: Shuai Zhang <quic_shuaz@xxxxxxxxxxx>
>> ---
> 
> Please read
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> 
> and adjust your commit message accordingly.
> 
>>  drivers/bluetooth/hci_qca.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index 50ec9b155..33c2dd7b8 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1662,11 +1662,14 @@ static void qca_hw_error(struct hci_dev *hdev, u8 code)
>>  	 *
>>  	 * Host will not download the firmware after SSR, controller to remain
>>  	 * in the IBS_WAKE state, and the host needs to synchronize with it
>> +	 *
>> +	 * clear memcoredump_flag to ensure next submission of coredump date.
> 
> "Since the bluetooth chip has been reset, clear the memdump state"
> 
> Konrad
> 

I will update.

>>  	 */
>>  	if (!test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks)) {
>>  		clear_bit(QCA_SSR_TRIGGERED, &qca->flags);
>>  		clear_bit(QCA_IBS_DISABLED, &qca->flags);
>>  		qca->tx_ibs_state = HCI_IBS_TX_AWAKE;
>> +		qca->memdump_state = QCA_MEMDUMP_IDLE;
>>  		msleep(50);
>>  	}
>>  

BR,
Shuai





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux