On Mon, 2025-08-11 at 16:16 -0400, Luiz Augusto von Dentz wrote: > Hi Bastien, > > On Mon, Aug 11, 2025 at 3:59 PM Bastien Nocera <hadess@xxxxxxxxxx> > wrote: > > > > Add the ell library as a subproject. Rather than doing like > > autotools > > and relying on users checking out ell in a particular location, or > > install ell as a system shared library, use meson subprojects to > > build > > our own internal copy of ell if the user hasn't installed it > > system-wide. > > > > Note that this currently points to a fork of ell with meson support > > added, this should be switched to the upstream repo when that > > support is > > merged. See: > > https://lore.kernel.org/ell/20250807134859.930870-1-hadess@xxxxxxxxxx/T/ > > Ok, well then we will depend on ell switching to meson first, have > you > received any feedback if that is going to be accepted? Perhaps we > could just turn it into a regular dependency instead of requiring to > copy its source code since that was done due to distro not packaging > libell back when it was introduced, but maybe that has changed since > then. > > Anyway I do agree it is quite ugly what we are doing, requiring ell > on > a specific to build and the usage of submodule is probably the right > thing to do if we don't want to deal with a system dependency. The submodule is only used with meson. meson will automatically fallback to the system version of the library if present. I didn't make any changes to the autotools build. About the ell meson patches, I haven't received feedback yet, but I'll poke again now. > > > --- > > .gitignore | 1 - > > .gitmodules | 3 +++ > > subprojects/ell | 1 + > > 3 files changed, 4 insertions(+), 1 deletion(-) > > create mode 100644 .gitmodules > > create mode 160000 subprojects/ell > > > > diff --git a/.gitignore b/.gitignore > > index d23a06af4b53..3da0ac680152 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -35,7 +35,6 @@ test-driver > > test-suite.log > > coverage.info > > coverage > > -ell > > > > lib/bluez.pc > > src/builtin.h > > diff --git a/.gitmodules b/.gitmodules > > new file mode 100644 > > index 000000000000..53881e4d8e3f > > --- /dev/null > > +++ b/.gitmodules > > @@ -0,0 +1,3 @@ > > +[submodule "subprojects/ell"] > > + path = subprojects/ell > > + url = https://github.com/hadess/ell.git > > diff --git a/subprojects/ell b/subprojects/ell > > new file mode 160000 > > index 000000000000..08bc5f26f210 > > --- /dev/null > > +++ b/subprojects/ell > > @@ -0,0 +1 @@ > > +Subproject commit 08bc5f26f2108a778a25222fdc60b931310ad68d > > -- > > 2.50.0 > > > > >
