Re: [PATCH] lib/uuid: Do not use mixed-case letters in UUIDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Arkadiusz,


Thank you for your patch.

Am 08.08.25 um 19:06 schrieb Arkadiusz Bokowy:

Maybe mention, that you settled on lower case, or make the summary more specific: lib/uuid: Make mixed-case letter UUIDs lowercase.

Also, your Signed-off-by: line is missing.

---
  lib/uuid.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/uuid.h b/lib/uuid.h
index 479986f06..67cb1b92b 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -50,7 +50,7 @@ extern "C" {
  #define BATTERY_UUID		"0000180f-0000-1000-8000-00805f9b34fb"
  #define SCAN_PARAMETERS_UUID	"00001813-0000-1000-8000-00805f9b34fb"
-#define SAP_UUID "0000112D-0000-1000-8000-00805f9b34fb"
+#define SAP_UUID		"0000112d-0000-1000-8000-00805f9b34fb"
#define HEART_RATE_UUID "0000180d-0000-1000-8000-00805f9b34fb"
  #define HEART_RATE_MEASUREMENT_UUID	"00002a37-0000-1000-8000-00805f9b34fb"
@@ -164,7 +164,7 @@ extern "C" {
  #define BAA_SERVICE_UUID	"00001851-0000-1000-8000-00805f9b34fb"
#define ASHA_SERVICE 0xFDF0
-#define ASHA_PROFILE_UUID	"0000FDF0-0000-1000-8000-00805f9b34fb"
+#define ASHA_PROFILE_UUID	"0000fdf0-0000-1000-8000-00805f9b34fb"
#define PAC_CONTEXT 0x2bcd
  #define PAC_SUPPORTED_CONTEXT				0x2bce

With the formalities fixed:

Reviewed-by: Paul Menzel


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux