From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
getpeername can either return an error set in the errno or the
returned size can be invalid but in that case errno is not set so
printing it would generate bogus message.
---
btio/btio.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/btio/btio.c b/btio/btio.c
index 30804cab96af..43275cb86e89 100644
--- a/btio/btio.c
+++ b/btio/btio.c
@@ -1665,12 +1665,16 @@ static bool get_bc_sid(int sock, uint8_t *sid, GError **err)
olen = sizeof(addr);
memset(&addr, 0, olen);
- if (getpeername(sock, (void *)&addr, &olen) < 0 ||
- olen != sizeof(addr)) {
+ if (getpeername(sock, (void *)&addr, &olen) < 0) {
ERROR_FAILED(err, "getpeername", errno);
return false;
}
+ if (olen != sizeof(addr)) {
+ ERROR_FAILED(err, "getpeername: size mismatch", EINVAL);
+ return false;
+ }
+
*sid = addr.iso.iso_bc->bc_sid;
return true;
--
2.50.1
