Hi Kiran, On Wed, Jul 23, 2025 at 9:34 AM Kiran K <kiran.k@xxxxxxxxx> wrote: > > Add support for the BlazarIW Bluetooth core used in the Wildcat Lake > platform. > > dmesg: > Bluetooth: Core ver 2.22 > Bluetooth: HCI device and connection manager initialized > Bluetooth: HCI socket layer initialized > Bluetooth: L2CAP socket layer initialized > Bluetooth: SCO socket layer initialized > Bluetooth: hci0: Device revision is 0 > Bluetooth: hci0: Secure boot is enabled > Bluetooth: hci0: OTP lock is disabled > Bluetooth: hci0: API lock is disabled > Bluetooth: hci0: Debug lock is disabled > Bluetooth: hci0: Minimum firmware build 1 week 10 2014 > Bluetooth: hci0: Bootloader timestamp 2023.33 buildtype 1 build 45995 > Bluetooth: hci0: Found device firmware: intel/ibt-1190-00a1-iml.sfi > Bluetooth: hci0: Boot Address: 0x30098800 > Bluetooth: hci0: Firmware Version: 184-28.25 > Bluetooth: hci0: Waiting for firmware download to complete > Bluetooth: hci0: Firmware loaded in 67426 usecs > Bluetooth: hci0: Waiting for device to boot > Bluetooth: hci0: Device booted in 2248 usecs > Bluetooth: hci0: Waiting for device transition to d0 > Bluetooth: hci0: Device moved to D0 in 0 usecs > Bluetooth: hci0: dsbr: enable: 0x01 value: 0x0f > Bluetooth: hci0: Found device firmware: intel/ibt-1190-00a1-pci.sfi > Bluetooth: hci0: Boot Address: 0x10000800 > Bluetooth: hci0: Firmware Version: 184-28.25 > Bluetooth: hci0: Waiting for firmware download to complete > Bluetooth: hci0: Firmware loaded in 510990 usecs > Bluetooth: hci0: Waiting for device to boot > Bluetooth: hci0: Device booted in 39057 usecs > Bluetooth: hci0: Waiting for device transition to d0 > Bluetooth: hci0: Device moved to D0 in 88 usecs > Bluetooth: hci0: Found Intel DDC parameters: intel/ibt-1190-00a1-pci.ddc > Bluetooth: hci0: Applying Intel DDC parameters completed > Bluetooth: hci0: Firmware timestamp 2025.28 buildtype 1 build 96440 > Bluetooth: hci0: Firmware SHA1: 0x34b85c16 > Bluetooth: hci0: Fseq status: Success (0x00) > Bluetooth: hci0: Fseq executed: 00.98.00.05 > Bluetooth: hci0: Fseq BT Top: 00.98.00.05 > Bluetooth: BNEP (Ethernet Emulation) ver 1.3 > Bluetooth: BNEP filters: protocol multicast > Bluetooth: BNEP socket layer initialized > Bluetooth: MGMT ver 1.23 > Bluetooth: RFCOMM TTY layer initialized > Bluetooth: RFCOMM socket layer initialized > Bluetooth: RFCOMM ver 1.11 lspci is probably better than dmesg when adding new models since what matters here, or there is no change in the lspci? If it doesn't them it probably better to add the response of Read Version TLV, we do have decoding of it: https://github.com/bluez/bluez/blob/3c0693c5d22606f786da4389103740424a04213b/monitor/intel.c#L297 Perhaps we should add a decoding for the version code name rather than just print version number, anyway dmesg is just not useful in general and we actually should reduce the amount of information we print there using bt_dev_info. > Signed-off-by: Vijay Satija <vijay.satija@xxxxxxxxx> > Signed-off-by: Kiran K <kiran.k@xxxxxxxxx> > --- > drivers/bluetooth/btintel.c | 3 +++ > drivers/bluetooth/btintel_pcie.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > index be69d21c9aa7..9d29ab811f80 100644 > --- a/drivers/bluetooth/btintel.c > +++ b/drivers/bluetooth/btintel.c > @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev, > case 0x1d: /* BlazarU (BzrU) */ > case 0x1e: /* BlazarI (Bzr) */ > case 0x1f: /* Scorpious Peak */ > + case 0x22: /* BlazarIW (BzrIW) */ > break; > default: > bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)", > @@ -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) > case 0x1d: > case 0x1e: > case 0x1f: > + case 0x22: > hci_set_msft_opcode(hdev, 0xFC1E); > break; > default: > @@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) > case 0x1d: > case 0x1e: > case 0x1f: > + case 0x22: > /* Display version information of TLV type */ > btintel_version_info_tlv(hdev, &ver_tlv); > > diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c > index 6e7bbbd35279..d08f59ae7720 100644 > --- a/drivers/bluetooth/btintel_pcie.c > +++ b/drivers/bluetooth/btintel_pcie.c > @@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct hci_dev *hdev) > switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) { > case 0x1e: /* BzrI */ > case 0x1f: /* ScP */ > + case 0x22: /* BzrIW */ > /* Display version information of TLV type */ > btintel_version_info_tlv(hdev, &ver_tlv); > > -- > 2.43.0 > > -- Luiz Augusto von Dentz