Hi Paul,
Thanks for the comments.
>-----Original Message-----
>From: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
>Sent: Wednesday, July 23, 2025 11:51 AM
>To: K, Kiran <kiran.k@xxxxxxxxx>
>Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Srivatsa, Ravishankar
><ravishankar.srivatsa@xxxxxxxxx>; Vijay Satija <vijay.satija@xxxxxxxxx>
>Subject: Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW core
>
>Dear Kiran,
>
>
>Am 23.07.25 um 08:26 schrieb Kiran K:
>> Need to add support for BlazarIW Bluetooth core used in Wildcat Lake
>> platform.
>
>Need to … sounds strange for a commit message.
Ack. I will modify the commit message.
>
>Where is the id from? It’d be great if you added the datasheet name and
>revision.
Id comes from hardware requirements which is maintained in JIRAs.
>
>Also, how did you test this?
It was tested on silicon. May be I can add the firmware download messages from dmesg.
>
>> Signed-off-by: Vijay Satija <vijay.satija@xxxxxxxxx>
>> Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
>> ---
>> drivers/bluetooth/btintel.c | 3 +++
>> drivers/bluetooth/btintel_pcie.c | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index be69d21c9aa7..ea1521c6b2d3 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,
>> case 0x1d: /* BlazarU (BzrU) */
>> case 0x1e: /* BlazarI (Bzr) */
>> case 0x1f: /* Scorpious Peak */
>> + case 0x22: /* BlazarIW (BzrIW */
>
>Missing closing ).
Ack
>
>> break;
>> default:
>> bt_dev_err(hdev, "Unsupported Intel hardware variant
>(0x%x)", @@
>> -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8
>hw_variant)
>> case 0x1d:
>> case 0x1e:
>> case 0x1f:
>> + case 0x22:
>> hci_set_msft_opcode(hdev, 0xFC1E);
>> break;
>> default:
>> @@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev
>*hdev)
>> case 0x1d:
>> case 0x1e:
>> case 0x1f:
>> + case 0x22:
>> /* Display version information of TLV type */
>> btintel_version_info_tlv(hdev, &ver_tlv);
>>
>> diff --git a/drivers/bluetooth/btintel_pcie.c
>> b/drivers/bluetooth/btintel_pcie.c
>> index 6e7bbbd35279..d08f59ae7720 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -2149,6 +2149,7 @@ static int btintel_pcie_setup_internal(struct
>hci_dev *hdev)
>> switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) {
>> case 0x1e: /* BzrI */
>> case 0x1f: /* ScP */
>> + case 0x22: /* BzrIW */
>> /* Display version information of TLV type */
>> btintel_version_info_tlv(hdev, &ver_tlv);
>>
>
>The rest looks good.
>
>
>Kind regards,
>
>Paul
Thanks,
Kiran
