Hi Kiran, Ivan,
On Tue, Jul 15, 2025 at 12:31 AM Ivan Pravdin
<ipravdin.official@xxxxxxxxx> wrote:
>
> On Tue, Jul 15, 2025 at 08:33:18AM GMT, Kiran K wrote:
> > hci_ll.c: In function ‘ll_setup’:
> > hci_ll.c:656:68: error: ‘struct hci_dev’ has no member
> > named ‘quirks’
> > set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> >
> > Fixes: be736f5f89d5 ("Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap")
> > Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
I went ahead and amend the original change adding your signed-off and tested-by.
> > ---
> > drivers/bluetooth/hci_ll.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
> > index e19e9bd49555..7044c86325ce 100644
> > --- a/drivers/bluetooth/hci_ll.c
> > +++ b/drivers/bluetooth/hci_ll.c
> > @@ -649,11 +649,11 @@ static int ll_setup(struct hci_uart *hu)
> > /* This means that there was an error getting the BD address
> > * during probe, so mark the device as having a bad address.
> > */
> > - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> > + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> > } else if (bacmp(&lldev->bdaddr, BDADDR_ANY)) {
> > err = ll_set_bdaddr(hu->hdev, &lldev->bdaddr);
> > if (err)
> > - set_bit(HCI_QUIRK_INVALID_BDADDR, &hu->hdev->quirks);
> > + hci_set_quirk(hu->hdev, HCI_QUIRK_INVALID_BDADDR);
> > }
> >
> > /* Operational speed if any */
> > --
> > 2.43.0
> >
>
> Tested-by: Ivan Pravdin <ipravdin.official@xxxxxxxxx>
>
> Ivan Pravdin
>
--
Luiz Augusto von Dentz
