> If bt_skb_alloc() fails, ret should be -ENOMEM then pass to ERR_PTR(). You would like to achieve a more appropriate error code for another case. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94 … > +++ b/drivers/bluetooth/btrtl.c > @@ -1137,8 +1137,10 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev, > > if (btrtl_dev->drop_fw) { > skb = bt_skb_alloc(sizeof(*cmd), GFP_KERNEL); > - if (!skb) > + if (!skb) { > + ret = -ENOMEM; > goto err_free; > + } > > cmd = skb_put(skb, HCI_COMMAND_HDR_SIZE); … Will it be a bit nicer to perform the desired variable assignment after an additional label like “err_no_mem”? Regards, Markus
