Re: [PATCH BlueZ v3 0/4] Fix bugs found by static analysis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ismagil,

On Wed, Jul 9, 2025 at 8:21 AM Ismagil Iskakov <i.iskakov@xxxxxx> wrote:
>
> btio: fix range validation of security level
> Expression is used as an index for accessing
> an array's element in function 'l2cap_set_lm'.
> This expression can have value 4, which is out
> of range, as indicated by a preceding
> conditional expression.
>
> profiles/audio: add nullity checks
> Return value of a function 'btd_device_get_service'
> is dereferenced without checking for NULL, but it
> is usually checked for this function (28/35).
> Return value of a function 'queue_find' is
> dereferenced without checking for NULL, but it
> is usually checked for this function (182/183).
>
> src/shared: add nullity checks
> Return value of a function 'util_iov_pull_mem'
> is dereferenced without checking for NULL, but it
> is usually checked for this function (64/80).
> Return value of a function 'vcp_get_vcs' is
> dereferenced without checking for NULL, but it is
> usually checked for this function (4/5).
>
> obexd/client: fix err condition causing memleak
> Dynamic memory, referenced by 'err', is allocated
> by calling function 'obc_transfer_get' and lost
> at bip.c:139.
>
> Ismagil Iskakov (4):
>   btio: fix range validation of security level
>   profiles/audio: add nullity checks
>   src/shared: add nullity checks
>   obexd/client: fix err condition causing memleak
>
>  btio/btio.c             |  6 ++++++
>  obexd/client/transfer.c |  2 +-
>  profiles/audio/a2dp.c   | 35 +++++++++++++++++++++++++----------
>  profiles/audio/avrcp.c  | 24 +++++++++++++++++++++---
>  profiles/audio/bass.c   |  3 +++
>  src/shared/bap.c        | 23 +++++++++++++++++++++++
>  src/shared/vcp.c        |  3 +++
>  7 files changed, 82 insertions(+), 14 deletions(-)
>
> --
> 2.34.1

There are some coding style problem catch by checkpack:

https://github.com/bluez/bluez/pull/1413/commits/b55a78ea5a866b48d8051fd9a2e15d2abc1d15d3

Please fix those.

>


-- 
Luiz Augusto von Dentz





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux