Hi Ismagil, On Tue, Jul 8, 2025 at 7:12 AM Ismagil Iskakov <i.iskakov@xxxxxx> wrote: > > Seems like a breaking bug. Analogous to bt_bap_stream_io_link, > but there the order is correct. The order doesn't change anything, the exact same operations are performed on both parameters, we could just name it stream and stream1 instead of link if that confuses the static analyzer, that said I don't think that should use the argument names are indication of the semantics of the function, specially since it can see the underline code. > --- > profiles/audio/bass.c | 2 +- > profiles/audio/transport.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c > index f617efa2c..e1c05e05a 100644 > --- a/profiles/audio/bass.c > +++ b/profiles/audio/bass.c > @@ -457,7 +457,7 @@ static void stream_unlink(void *data, void *user_data) > struct bt_bap_stream *link = data; > struct bt_bap_stream *stream = user_data; > > - bt_bap_stream_io_unlink(link, stream); > + bt_bap_stream_io_unlink(stream, link); > } > > static void bass_remove_bis(struct bass_setup *setup) > diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c > index a1fdf948b..a355bde24 100644 > --- a/profiles/audio/transport.c > +++ b/profiles/audio/transport.c > @@ -2015,7 +2015,7 @@ static void transport_unlink(void *data, void *user_data) > return; > } > > - bt_bap_stream_io_unlink(link, stream); > + bt_bap_stream_io_unlink(stream, link); > > bap_update_links(transport); > > -- > 2.34.1 > > -- Luiz Augusto von Dentz
