Re: [PATCH BlueZ v2 05/11] obexd/client: fix err condition causing memleak

[Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>]

Hi Ismagil,

On Tue, Jul 8, 2025 at 7:11 AM Ismagil Iskakov <i.iskakov@xxxxxx> wrote:
>
> transfer_open returns 0 if an error occurs, condition corrected.

It actually returns a boolean.

> ---
>  obexd/client/transfer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/obexd/client/transfer.c b/obexd/client/transfer.c
> index a7d00896f..b078c1f6c 100644
> --- a/obexd/client/transfer.c
> +++ b/obexd/client/transfer.c
> @@ -556,7 +556,7 @@ struct obc_transfer *obc_transfer_get(const char *type, const char *name,
>         transfer = obc_transfer_create(G_OBEX_OP_GET, filename, name, type);
>
>         perr = transfer_open(transfer, O_WRONLY | O_CREAT | O_TRUNC, 0600, err);
> -       if (perr < 0) {
> +       if (perr == FALSE) {

if (!perr)

>                 obc_transfer_free(transfer);
>                 return NULL;
>         }
> --
> 2.34.1
>
>


-- 
Luiz Augusto von Dentz