Re: [PATCH BlueZ bluez] shared/bap: Set stream to idle when I/O is disconnected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2025/6/24 21:08, Luiz Augusto von Dentz 写道:
[ EXTERNAL EMAIL ]

Hi,

On Tue, Jun 24, 2025 at 2:04 AM Yang Li via B4 Relay
<devnull+yang.li.amlogic.com@xxxxxxxxxx> wrote:
From: Yang Li <yang.li@xxxxxxxxxxx>

When the CIS link is disconnected, the ASE status transitions from Releasing to
Idle.

   > HCI Event: Disconnect Complete (0x05) plen 4           #1484 [hci0] 67.947425
                 Status: Success (0x00)
                 Handle: 512 Address: 5C:B1:E1:2F:01:B9 (Resolvable)
                 Identity type: Random (0x01)
                 Identity: E8:D5:2B:59:57:A6 (Static)
                 Reason: Remote User Terminated Connection (0x13)
   = bluetoothd: src/shared/bap.c:stream_io_disconnected() stream 0x..   67.948018
   = bluetoothd: src/shared/bap.c:bap_ucast_set_state() stream 0xdff..   67.948145
   = bluetoothd: src/shared/bap.c:stream_notify() stream 0xdffda8 st..   67.948275
   = bluetoothd: src/gatt-database.c:send_notification_to_device() G..   67.948525
   = bluetoothd: profiles/audio/bap.c:bap_state() stream 0xdffda8: r..   67.948679
   = bluetoothd: profiles/audio/transport.c:bap_state_changed() stre..   67.948967
   = bluetoothd: profiles/audio/transport.c:transport_update_playing..   67.949061
   = bluetoothd: profiles/audio/transport.c:media_transport_remove_o..   67.949106
   = bluetoothd: profiles/audio/transport.c:media_owner_free() Owner..   67.949149
   = bluetoothd: profiles/audio/transport.c:media_transport_suspend(..   67.949375
   = bluetoothd: profiles/audio/transport.c:transport_set_state() St..   67.949423
   = bluetoothd: src/shared/bap.c:bap_ucast_detach() stream 0xdffda8..   67.949574
   = bluetoothd: profiles/audio/media.c:pac_clear() endpoint 0xdd2d2..   67.949710

When BIG sync is lost, the stream status transitions from Streaming to Idle.

   > HCI Event: LE Meta Event (0x3e) plen 3                #3189 [hci0] 118.870863
         LE Broadcast Isochronous Group Sync Lost (0x1e)
                 BIG Handle: 0x00
                 Reason: Remote User Terminated Connection (0x13)
   = bluetoothd: src/shared/bap.c:stream_io_disconnected() stream 0..   118.871183
   = bluetoothd: src/shared/bap.c:bap_bcast_set_state() stream 0xdf..   118.871227
   = bluetoothd: profiles/audio/bap.c:bap_state_bcast_sink() stream..   118.871258
   = bluetoothd: profiles/audio/bass.c:bap_state_changed() stream 0..   118.871307
   = bluetoothd: src/gatt-database.c:send_notification_to_device()...   118.871384
   = bluetoothd: profiles/audio/transport.c:bap_state_changed() str..   118.871452
   = bluetoothd: profiles/audio/transport.c:transport_bap_update_li..   118.871509
   = bluetoothd: profiles/audio/transport.c:transport_update_playin..   118.871555
   = bluetoothd: profiles/audio/transport.c:transport_set_state() S..   118.871610
   = bluetoothd: src/shared/bap.c:bap_bcast_sink_detach() stream 0x..   118.871660
   = bluetoothd: profiles/audio/media.c:pac_clear() endpoint 0xdd25..   118.871689

Fixes: https://github.com/bluez/bluez/issues/1343

Signed-off-by: Yang Li <yang.li@xxxxxxxxxxx>
---
  src/shared/bap.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index bccbc73ff..d51f3106e 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -6584,10 +6584,8 @@ static bool stream_io_disconnected(struct io *io, void *user_data)

         DBG(stream->bap, "stream %p io disconnected", stream);

-       if (stream->ep->state == BT_ASCS_ASE_STATE_RELEASING)
-               stream_set_state(stream, BT_BAP_STREAM_STATE_CONFIG);
This is actually on purpose for unicast since that supports caching
the configuration, now perhaps this is not the case for broadcast
since the BIG may have been terminated so we probably need to check if
this is a broadcast stream or a unicast stream, or add a dedicated
callback for each type.


Regarding the Unicast caching configuration you mentioned, there is currently an issue in the code flow. The relevant log is shown below:

When music is paused on the pixel 9 phone, the CIS link gets disconnected. As the transport state changes from ACTIVE to IDLE, the stream state transitions from config to qos.

  > HCI Event: Disconnect Complete (0x05) plen 4           #1425 [hci0] 49.572089
          Status: Success (0x00)
          Handle: 512 Address: 6A:AB:51:47:3B:80 (Resolvable)
            Identity type: Random (0x01)
            Identity: E8:D5:2B:59:57:A6 (Static)
          Reason: Remote User Terminated Connection (0x13)
  bluetoothd[2313]: src/shared/bap.c:stream_io_disconnected() stream 0x1f9fc20 io disconnected   bluetoothd[2313]: src/shared/bap.c:bap_ucast_set_state() stream 0x1f9fc20 dir 0x01: releasing -> config   bluetoothd[2313]: src/shared/bap.c:stream_notify() stream 0x1f9fc20 state 1   bluetoothd[2313]: profiles/audio/transport.c:bap_state_changed() stream 0x1f9fc20: releasing(6) -> config(1)   bluetoothd[2313]: profiles/audio/transport.c:transport_update_playing() /org/bluez/hci0/dev_6A_AB_51_47_3B_80/fd1 State=TRANSPORT_STATE_ACTIVE Playing=0   bluetoothd[2313]: profiles/audio/transport.c:media_transport_remove_owner() Transport /org/bluez/hci0/dev_6A_AB_51_47_3B_80/fd1 Owner :1.1   bluetoothd[2313]: profiles/audio/transport.c:media_owner_free() Owner :1.1   bluetoothd[2313]: profiles/audio/transport.c:media_transport_suspend() Transport /org/bluez/hci0/dev_6A_AB_51_47_3B_80/fd1 Owner   bluetoothd[2313]: profiles/audio/transport.c:transport_set_state() State changed /org/bluez/hci0/dev_6A_AB_51_47_3B_80/fd1: TRANSPORT_STATE_ACTIVE -> TRANSPORT_STATE_IDLE
  bluetoothd[2313]: src/shared/bap.c:stream_disable() stream 0x1f9fc20
  bluetoothd[2313]: src/shared/bap.c:bap_ucast_set_state() stream 0x1f9fc20 dir 0x01: config -> qos   ATTbluetoothd[2313]: < ACL Data TX: H.. flags 0x00 dlen 51 #1426 [hci0] 49.585656
      ATT: Handle Value Notification (0x1b) len 46
        Handle: 0x007b Type: Sink ASE (0x2bc4)
          Data[44]: 01010002050a00204e00409c00204e00409c0006000000001302010302020105030300000003042800020501
            ASE ID: 1
            State: Codec Configured (0x01)
            Framing: Unframed PDUs supported (0x00)
            PHY: 0x02
            LE 2M PHY preffered (0x02)
            RTN: 5
            Max Transport Latency: 10
            Presentation Delay Min: 20000 us
  ...
  bluetoothd[2313]: < ACL Data TX: H.. flags 0x00 dlen 24 #1427 [hci0] 49.585725
      ATT: Handle Value Notification (0x1b) len 19
        Handle: 0x007b Type: Sink ASE (0x2bc4)
          Data[17]: 0102010010270000025000050a00204e00
            ASE ID: 1
            State: QoS Configured (0x02)
            CIG ID: 0x01
            CIS ID: 0x00
  ...

when playback resumes on the phone, it attempts to set the ASE state to Codec. However, since the stream has already transitioned from config to qos, the phone ends up disconnecting the connection.

  bluetoothd[2313]: < ACL Data TX: H.. flags 0x00 dlen 12  #1433 [hci0] 60.216004
      ATT: Handle Value Notification (0x1b) len 7
        Handle: 0x0087 Type: ASE Control Point (0x2bc6)
          Data[5]: 0101010000
            Opcode: Codec Configuration (0x01)
            Number of ASE(s): 1
            ASE: #0
            ASE ID: 0x01
            ASE Response Code: Success (0x00)
            ASE Response Reason: None (0x00)
  bluetoothd[2313]: < ACL Data TX: H.. flags 0x00 dlen 51 #1434 [hci0] 60.226086
      ATT: Handle Value Notification (0x1b) len 46
        Handle: 0x007b Type: Sink ASE (0x2bc4)
          Data[44]: 01010002050a00204e00409c00204e00409c0006000000001302010302020105030300000003042800020501
            ASE ID: 1
            State: Codec Configured (0x01)
            Framing: Unframed PDUs supported (0x00)
            PHY: 0x02
            LE 2M PHY preffered (0x02)
            RTN: 5
            Max Transport Latency: 10
            Presentation Delay Min: 20000 us
            Presentation Delay Max: 40000 us
            Preferred Presentation Delay Min: 20000 us
            Preferred Presentation Delay Max: 40000 us
            Codec: LC3 (0x06)
            Codec Specific Configuration: #0: len 0x02 type 0x01
              Sampling Frequency: 16 Khz (0x03)
            Codec Specific Configuration: #1: len 0x02 type 0x02
              Frame Duration: 10 ms (0x01)
            Codec Specific Configuration: #2: len 0x05 type 0x03
           Location: 0x00000003
              Front Left (0x00000001)
              Front Right (0x00000002)
            Codec Specific Configuration: #3: len 0x03 type 0x04
              Frame Length: 40 (0x0028)
            Codec Specific Configuration: #4: len 0x02 type 0x05
              Frame Blocks per SDU: 1 (0x01)

  ...

  > HCI Event: Disconnect Complete (0x05) plen 4           #1445 [hci0] 63.651497
        Status: Success (0x00)
        Handle: 16 Address: 6A:AB:51:47:3B:80 (Resolvable)
          Identity type: Random (0x01)
          Identity: E8:D5:2B:59:57:A6 (Static)
        Reason: Remote User Terminated Connection (0x13)

Introducing a check in the stream logic to distinguish between Unicast and Broadcast would indeed make it easier to handle different stream types cleanly. However, if we temporarily ignore Unicast caching, a simpler and cleaner approach would be to transition the stream directly to IDLE when I/O is disconnected.

Once the Unicast caching issue is properly resolved, we can revisit and introduce stream-type-based handling accordingly.

+       stream_set_state(stream, BT_BAP_STREAM_STATE_IDLE);

-       bt_bap_stream_set_io(stream, -1);
         return false;
  }


---
base-commit: ae1b7f6ba805f82742bbc32ff275e268248ef9f8
change-id: 20250624-bap_for_big_sync_lost-63476c679dbb

Best regards,
--
Yang Li <yang.li@xxxxxxxxxxx>




--
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux